clebertsuconic commented on PR #4200: URL: https://github.com/apache/activemq-artemis/pull/4200#issuecomment-1255375025
@MM53 instead of asking you do perform a few changes, I am doing the simple changes I was going to ask you to do, and I'm amending them as you.. you still get authorship on the git logs.. (It was just easier to do it that way). Please take a look on the final result of the commit. look at what I did on the test where I made the class non final, and made the test to return a fake time. I had to do this because your test was not actually failing. The assertion was passing for something else. I made usage of the AssertionLoggerHandler where we use it in a few other tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
