cshannon commented on code in PR #965:
URL: https://github.com/apache/activemq/pull/965#discussion_r1099235884
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/policy/AbstractDeadLetterStrategy.java:
##########
@@ -31,13 +31,15 @@ public abstract class AbstractDeadLetterStrategy implements
DeadLetterStrategy {
private boolean processNonPersistent = false;
private boolean processExpired = true;
private boolean enableAudit = true;
- private final ActiveMQMessageAudit messageAudit = new
ActiveMQMessageAudit();
Review Comment:
Also if we decide to not have a flag for Individual and only use a message
audit per destination (which I think makes more sense) then we can actually
just move this message audit variable down into the Shared strategy. The
abstract wouldn't need to have anything defined except the abstract method for
looking up the message audit as leaving this here wouldn't make sense if it
won't be used by Individual.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
