gemmellr commented on code in PR #4363:
URL: https://github.com/apache/activemq-artemis/pull/4363#discussion_r1108483179


##########
tests/leak-tests/pom.xml:
##########
@@ -0,0 +1,488 @@
+<!--

Review Comment:
   Commented on some more that seem like they could go. I can live with the 
broker protocol dependencies since that is a representative-test thing.
   
   Not being able to easily look at whats there and see something is unused or 
unnecessary to declare (i.e purely transitive) as youve found, is precisely why 
it should start with the minimal appropriate and then only have things 
added/removed as we go.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to