jbertram commented on PR #4387:
URL:
https://github.com/apache/activemq-artemis/pull/4387#issuecomment-1452740405
You defined `logDebug` which takes a `Supplier<String>`, and you use it like
this, e.g.:
```java
logDebug(() -> String.format("Switch from OVER_SIZE to OVER_ELEMENTS
[currentSize=%s, currentElements=%s, lowerMarkSize=%s, maxElements=%s]",
currentSize, currentElements, lowerMarkSize, maxElements));
```
However, I don't see how that is preferable to just following the same
logging pattern that's used in the rest of the code-base, e.g.:
```java
logger.debug("Switch from OVER_SIZE to OVER_ELEMENTS [currentSize={},
currentElements={}, lowerMarkSize={}, maxElements={}]", currentSize,
currentElements, lowerMarkSize, maxElements);
```
Couple of other issues:
- All commits need to be squashed.
- Your commit message should conform to the pattern outlined in our [Hacking
Guide](https://github.com/apache/activemq-artemis/blob/main/docs/hacking-guide/en/code.md#commitMessageDetails).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
