tabish121 commented on code in PR #4721:
URL: https://github.com/apache/activemq-artemis/pull/4721#discussion_r1431901284
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederation.java:
##########
@@ -239,7 +243,7 @@ public synchronized AMQPFederation
addQueueMatchPolicy(FederationReceiveFromQueu
* @throws ActiveMQException if an error occurs processing the added policy
*/
public synchronized AMQPFederation
addAddressMatchPolicy(FederationReceiveFromAddressPolicy addressPolicy) throws
ActiveMQException {
- final FederationAddressPolicyManager manager = new
AMQPFederationAddressPolicyManager(this, addressPolicy);
+ final FederationAddressPolicyManager manager = new
AMQPFederationAddressPolicyManager(this, addressPolicy,
server.getConfiguration().isLargeMessageSync());
Review Comment:
You don't need it, that's the issue, the places it is use all have access to
ProtonAbstractReceiver which can call, getSessionContext() on it and ask if
sync is needed
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/federation/AMQPFederation.java:
##########
@@ -239,7 +243,7 @@ public synchronized AMQPFederation
addQueueMatchPolicy(FederationReceiveFromQueu
* @throws ActiveMQException if an error occurs processing the added policy
*/
public synchronized AMQPFederation
addAddressMatchPolicy(FederationReceiveFromAddressPolicy addressPolicy) throws
ActiveMQException {
- final FederationAddressPolicyManager manager = new
AMQPFederationAddressPolicyManager(this, addressPolicy);
+ final FederationAddressPolicyManager manager = new
AMQPFederationAddressPolicyManager(this, addressPolicy,
server.getConfiguration().isLargeMessageSync());
Review Comment:
You don't need it, that's the issue, the places it is used all have access
to ProtonAbstractReceiver which can call, getSessionContext() on it and ask if
sync is needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
