cshannon commented on PR #2071: URL: https://github.com/apache/activemq/pull/2071#issuecomment-4618011653
@mattrpav - This was refactored to remove the lazy loading supplier and to leverage the [existing callback](https://github.com/apache/activemq/blob/f84eb3968a02bb5a9698da508d66c56c72ccdaaf/activemq-broker/src/main/java/org/apache/activemq/broker/Broker.java#L278) that is called when the admin context is created that I didn't realize existed. I updated BrokerService start cycle to always guarantee this is called before it is needed (previously it was only called if destinations needed to be loaded). This refactoring ensures the object is created before it is attempted to be used. An extra sanity check is done during start() just to make sure it isn't null so we fail fast if someone changes something in the future and the initialization gets removed by mistake. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information, visit: https://activemq.apache.org/contact
