michaelandrepearce commented on a change in pull request #2561: ARTEMIS-2259
Client session not exist if reattach timeout
URL: https://github.com/apache/activemq-artemis/pull/2561#discussion_r261974837
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionFactoryImpl.java
##########
@@ -771,7 +771,11 @@ private void reconnectSessions(final RemotingConnection
oldConnection,
((CoreRemotingConnection)
connection).syncIDGeneratorSequence(((CoreRemotingConnection)
oldConnection).getIDGeneratorSequence());
for (ClientSessionInternal session : sessionsToFailover) {
- session.handleFailover(connection, cause);
+ if (session.handleFailover(connection, cause)) {
+ connection.destroy();
Review comment:
@clebertsuconic i think i have seen something similar in our production
environment, unfortunatly because its prod they restarted the client app too
quickly before details were gathered.
@wy96f as clebert notes, would be great to have a test case then i could
also tell if it is what ive also seen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
