cshannon commented on a change in pull request #349: AMQ-7159 - Adding a new
attribute on PersistenceAdapterViewMBean to s…
URL: https://github.com/apache/activemq/pull/349#discussion_r262901153
##########
File path:
activemq-kahadb-store/src/main/java/org/apache/activemq/store/kahadb/MessageDatabase.java
##########
@@ -249,6 +250,7 @@ public void writePayload(Metadata object, DataOutput
dataOut) throws IOException
protected PageFile pageFile;
protected Journal journal;
protected Metadata metadata = new Metadata();
+ protected PersistenceAdapterStatistics persistenceAdapterStatistics = new
PersistenceAdapterStatistics();
Review comment:
I would probably make this final and then I would also add a getter for this
object and also expose it under KahaDBPersistenceAdapter. I routinely use
embedded brokers for example and being able to access this through
KahaDBPersistenceAdapter without JMX would be nice. Inside
KahaDBPersistenceAdapter I would just return the actual
PersistenceAdapterStatistics object so someone could access it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
