gaohoward commented on a change in pull request #2579: ARTEMIS-2273 Adding
Audit Log
URL: https://github.com/apache/activemq-artemis/pull/2579#discussion_r264993517
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
##########
@@ -1516,6 +1541,9 @@ public synchronized RoutingStatus send(Transaction tx,
final boolean direct,
boolean noAutoCreateQueue,
RoutingContext routingContext)
throws Exception {
+ if (AuditLogger.isEnabled()) {
+ AuditLogger.sendMessage(this, getUsername(), tx, messageParameter,
direct, noAutoCreateQueue, routingContext);
Review comment:
the log format is different. and the logging plugin serves a different
purpose that auditing. (actually in amq5 they are totally different impls). and
it brings in extra config.
for hot path (actually so far there is only one sending message) I can use
log level to easily control it.
So I'd for the moment don't touch the logging plugin.
wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
