michaelandrepearce commented on a change in pull request #2602: ARTEMIS-2292 - Fix queue level auto-delete for topic subscription queue URL: https://github.com/apache/activemq-artemis/pull/2602#discussion_r271326552
########## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java ########## @@ -1582,7 +1582,7 @@ public void run() { public void run() { for (Queue queue : getLocalQueues()) { if (!queue.isInternalQueue() && QueueManagerImpl.isAutoDelete(queue) && QueueManagerImpl.consumerCountCheck(queue) && QueueManagerImpl.delayCheck(queue) && QueueManagerImpl.messageCountCheck(queue)) { - QueueManagerImpl.deleteAutoCreatedQueue(server, queue); + QueueManagerImpl.deleteAutoDeleteQueue(server, queue); Review comment: sure. just wanted better naming that was all. happy with your suggestion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services