jbertram commented on a change in pull request #2609: ARTEMIS-2294 implement
duplicate detection for AMQP
URL: https://github.com/apache/activemq-artemis/pull/2609#discussion_r272323801
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
##########
@@ -971,7 +971,7 @@ public Object getAMQPUserID() {
@Override
public Object getDuplicateProperty() {
- return null;
+ return
getObjectProperty(org.apache.activemq.artemis.api.core.Message.HDR_DUPLICATE_DETECTION_ID);
Review comment:
Nothing here precludes Service Bus from continuing to de-dupe by message ID
is there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
