jbertram edited a comment on issue #2609: ARTEMIS-2294 implement duplicate detection for AMQP URL: https://github.com/apache/activemq-artemis/pull/2609#issuecomment-480028367 To the point about application requirements in this use-case, there are definitely requirements for the application if it wants to handle duplicates both for sending and receiving. That's always been true (as far as I know) and this PR doesn't change anything in that regard. This PR is aimed at supporting the same duplicate detection for AMQP that we have for core. That's all. I've clarified this in the commit message and JIRA title. Additional functionality to de-duplicate AMQP messages based on message ID is beyond the scope of this PR, although that seems like a nice feature to have.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
