jmax01 commented on issue #2615: ARTEMIS-1230 Added artemis-bom
URL: https://github.com/apache/activemq-artemis/pull/2615#issuecomment-482290918
 
 
   I agree, but when submitting PR's I attempt to keep the focus as narrow as 
possible as that is what most projects prefer. 
   
   If it is agreed among the maintainers that they want to go all in I am more 
than will to submit another PR with those changes. 
   
   I think we would need another issue as the scope is a bit different than the 
original.
   
   > This = the pr/change your proposing.
   > 
   > Either everything follows the bom way or everything follows the existing. 
Its not good to have two approaches that change depending. It makes things 
actually worse.
   > 
   > I quite like the bom approach. But i think it needs to be more complete if 
we were to change artemis where it would be done for all.
   > 
   > I dont want a half way house personally. Its all in or all out.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to