clebertsuconic commented on a change in pull request #2619: ARTEMIS-2306
Support ActiveMQ5 feature JMSXGroupFirstForConsumer
URL: https://github.com/apache/activemq-artemis/pull/2619#discussion_r275849025
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
##########
@@ -876,7 +877,7 @@ public void
recreateConsumerOnServer(ClientConsumerInternal consumerInternal,
// We try to recreate any non-durable or auto-created queues, since they
might not be there on failover/reconnect.
// This allows e.g. JMS non durable subs and temporary queues to
continue to be used after failover/reconnection
if (!queueInfo.isDurable() || queueInfo.isAutoCreated()) {
- CreateQueueMessage_V2 createQueueRequest = new
CreateQueueMessage_V2(queueInfo.getAddress(), queueInfo.getName(),
queueInfo.getRoutingType(), queueInfo.getFilterString(), queueInfo.isDurable(),
queueInfo.isTemporary(), queueInfo.getMaxConsumers(),
queueInfo.isPurgeOnNoConsumers(), queueInfo.isAutoCreated(), false,
queueInfo.isExclusive(), queueInfo.isGroupRebalance(),
queueInfo.getGroupBuckets(), queueInfo.isLastValue(),
queueInfo.getLastValueKey(), queueInfo.isNonDestructive(),
queueInfo.getConsumersBeforeDispatch(), queueInfo.getDelayBeforeDispatch(),
queueInfo.isAutoDelete(), queueInfo.getAutoDeleteDelay(),
queueInfo.getAutoDeleteMessageCount());
Review comment:
why not use AddressSettings for such configuration instead of changing the
wire and the Client API?
I think such decision is better to be transparent from the client, and set
through server's configuration. Address-settings or some other generic setting?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
