clebertsuconic commented on a change in pull request #2627: ARTEMIS-2311
Dealing with Protocol conversions and JMSReplyTo
URL: https://github.com/apache/activemq-artemis/pull/2627#discussion_r276422094
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/CoreAmqpConverter.java
##########
@@ -530,4 +543,17 @@ private static byte destinationType(Destination
destination) {
throw new IllegalArgumentException("Unknown Destination Type passed to
JMS Transformer.");
}
+ private static byte destinationType(SimpleString destination) {
+ if
(destination.startsWith(ActiveMQDestination.QUEUE_QUALIFIED_PREFIX_SIMPLE))
+ return QUEUE_TYPE;
+ if
(destination.startsWith(ActiveMQDestination.TEMP_QUEUE_QUALIFED_PREFIX_SIMPLE))
+ return TEMP_QUEUE_TYPE;
+ if
(destination.startsWith(ActiveMQDestination.TOPIC_QUALIFIED_PREFIX_SIMPLE))
+ return TOPIC_TYPE;
+ if
(destination.startsWith(ActiveMQDestination.TEMP_TOPIC_QUALIFED_PREFIX_SIMPLE))
+ return TEMP_TOPIC_TYPE;
+
+ throw new IllegalArgumentException("Unknown Destination Type passed to
JMS Transformer.");
Review comment:
It's only used for JMSReplyTo property. but I will return Queue (as it does
now) just in case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
