michaelandrepearce commented on a change in pull request #2627: ARTEMIS-2311
Dealing with Protocol conversions and JMSReplyTo
URL: https://github.com/apache/activemq-artemis/pull/2627#discussion_r276438281
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireMessageConverter.java
##########
@@ -196,7 +200,21 @@ private OpenWireMessageConverter() {
final ActiveMQDestination replyTo = messageSend.getReplyTo();
if (replyTo != null) {
- putMsgReplyTo(replyTo, marshaller, coreMessage);
+ if (replyTo instanceof TemporaryQueue) {
+ MessageUtil.setJMSReplyTo(coreMessage,
org.apache.activemq.artemis.jms.client.ActiveMQDestination.TEMP_QUEUE_QUALIFED_PREFIX
+ (((TemporaryQueue) replyTo).getQueueName()));
Review comment:
and for doing it for OpenWire, we could levy its implementation, and like
wise for AMQP can use qpid-jms varient, as they also need to handle foreign
message. As such this could form the basis of the converters. And if any
issues, well then there is issue in that handling in the producers, to which
would need fixing anyhow, but least we aren't recoding and maintaining to sets
of conversion logics
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
