[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2634: ARTEMIS-2316 AMQPMessage missing ApplicationProperties from custom transformer

[GitBox]

michaelandrepearce commented on a change in pull request #2634: ARTEMIS-2316 
AMQPMessage missing ApplicationProperties from custom transformer
URL: https://github.com/apache/activemq-artemis/pull/2634#discussion_r277842217
 
 

 ##########
 File path: 
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
 ##########
 @@ -1395,128 +1397,162 @@ public SimpleString getSimpleStringProperty(String 
key) throws ActiveMQPropertyC
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putBooleanProperty(String key, boolean value) {
       getApplicationPropertiesMap(true).put(key, Boolean.valueOf(value));
+      messageChanged();
       return this;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message putByteProperty(String 
key, byte value) {
       getApplicationPropertiesMap(true).put(key, Byte.valueOf(value));
+      messageChanged();
       return this;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message putBytesProperty(String 
key, byte[] value) {
       getApplicationPropertiesMap(true).put(key, value);
+      messageChanged();
       return this;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message putShortProperty(String 
key, short value) {
       getApplicationPropertiesMap(true).put(key, Short.valueOf(value));
+      messageChanged();
       return this;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message putCharProperty(String 
key, char value) {
       getApplicationPropertiesMap(true).put(key, Character.valueOf(value));
+      messageChanged();
       return this;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message putIntProperty(String 
key, int value) {
       getApplicationPropertiesMap(true).put(key, Integer.valueOf(value));
+      messageChanged();
       return this;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message putLongProperty(String 
key, long value) {
       getApplicationPropertiesMap(true).put(key, Long.valueOf(value));
+      messageChanged();
       return this;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message putFloatProperty(String 
key, float value) {
       getApplicationPropertiesMap(true).put(key, Float.valueOf(value));
+      messageChanged();
       return this;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putDoubleProperty(String key, double value) {
       getApplicationPropertiesMap(true).put(key, Double.valueOf(value));
+      messageChanged();
       return this;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putBooleanProperty(SimpleString key, boolean value) {
       getApplicationPropertiesMap(true).put(key.toString(), 
Boolean.valueOf(value));
+      messageChanged();
       return this;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putByteProperty(SimpleString key, byte value) {
-      return putByteProperty(key.toString(), value);
+      org.apache.activemq.artemis.api.core.Message message = 
putByteProperty(key.toString(), value);
+      messageChanged();
+      return message;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putBytesProperty(SimpleString key, byte[] value) {
-      return putBytesProperty(key.toString(), value);
+      org.apache.activemq.artemis.api.core.Message message = 
putBytesProperty(key.toString(), value);
+      messageChanged();
+      return message;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putShortProperty(SimpleString key, short value) {
-      return putShortProperty(key.toString(), value);
+      org.apache.activemq.artemis.api.core.Message message = 
putShortProperty(key.toString(), value);
+      messageChanged();
+      return message;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putCharProperty(SimpleString key, char value) {
-      return putCharProperty(key.toString(), value);
+      org.apache.activemq.artemis.api.core.Message message = 
putCharProperty(key.toString(), value);
+      messageChanged();
+      return message;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putIntProperty(SimpleString key, int value) {
-      return putIntProperty(key.toString(), value);
+      org.apache.activemq.artemis.api.core.Message message = 
putIntProperty(key.toString(), value);
+      messageChanged();
+      return message;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putLongProperty(SimpleString key, long value) {
-      return putLongProperty(key.toString(), value);
+      org.apache.activemq.artemis.api.core.Message message = 
putLongProperty(key.toString(), value);
+      messageChanged();
+      return message;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putFloatProperty(SimpleString key, float value) {
-      return putFloatProperty(key.toString(), value);
+      org.apache.activemq.artemis.api.core.Message message = 
putFloatProperty(key.toString(), value);
+      messageChanged();
+      return message;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putDoubleProperty(SimpleString key, double value) {
-      return putDoubleProperty(key.toString(), value);
+      org.apache.activemq.artemis.api.core.Message message = 
putDoubleProperty(key.toString(), value);
+      messageChanged();
+      return message;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putStringProperty(String key, String value) {
       getApplicationPropertiesMap(true).put(key, value);
+      messageChanged();
       return this;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putObjectProperty(String key, Object value) throws 
ActiveMQPropertyConversionException {
       getApplicationPropertiesMap(true).put(key, value);
+      messageChanged();
       return this;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putObjectProperty(SimpleString key, Object value) throws 
ActiveMQPropertyConversionException {
-      return putObjectProperty(key.toString(), value);
+      org.apache.activemq.artemis.api.core.Message message = 
putObjectProperty(key.toString(), value);
+      messageChanged();
+      return message;
    }
 
    @Override
    public org.apache.activemq.artemis.api.core.Message 
putStringProperty(SimpleString key, SimpleString value) {
-      return putStringProperty(key.toString(), value.toString());
+      org.apache.activemq.artemis.api.core.Message message = 
putStringProperty(key.toString(), value.toString());
+      messageChanged();
 
 Review comment:
   ditto

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services