franz1981 edited a comment on issue #2633: ARTEMIS-2317 Avoid long TTSP caused by Page::read using mmap read URL: https://github.com/apache/activemq-artemis/pull/2633#issuecomment-486242847 > Can you simplify the change somehow it only fix the TTSP. If you still feel strong about the loop logic change, can you make it a separate commit? Sadly the loop logic using `FileChanne::read` is the solution of the issue: so I don't think it can be splitted, but I will cover as much as I can in order to make it robust as it was before. Re the logic I will make it more clear with comments, in order to be future proof :+1:
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
