clebertsuconic commented on a change in pull request #2640: ARTEMIS-2310
support system prop sub in xincludes
URL: https://github.com/apache/activemq-artemis/pull/2640#discussion_r278589112
##########
File path:
artemis-server/src/test/java/org/apache/activemq/artemis/core/config/impl/FileConfigurationTest.java
##########
@@ -64,6 +64,13 @@
public class FileConfigurationTest extends ConfigurationImplTest {
+ static {
Review comment:
Please, do not leave stuff after tests.
There's a rule on ActiveMQTestBae to cleanup properties, and that's probably
why your test failed here.
So, you should use a BeforeClass and AFterClass to cleanup such thing.
I'm adding here and squashing the change as yours.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
