franz1981 commented on a change in pull request #2649: NO-JIRA Fix test
URL: https://github.com/apache/activemq-artemis/pull/2649#discussion_r279089167
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/paging/GlobalPagingTest.java
##########
@@ -334,7 +334,7 @@ public void
testManagementMessageRequestCannotFailAfterFailedDirectDeliver() thr
final MessageReference reference =
MessageReference.Factory.createReference(session.createMessage(false), queue);
//it will cause QueueImpl::directDeliver -> false
queue.addHead(reference, false);
- Assert.assertSame(reference,
queue.removeReferenceWithID(reference.getMessageID()));
+ queue.removeReferenceWithID(reference.getMessageID());
Review comment:
But it can be null, is just mater of timing: the remove itself is not
necessary to the test TBH (I've written that test)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
