jdanekrh commented on a change in pull request #2652: ARTEMIS-2320 Assorted
small code fixes, mostly from IntelliJ autofixes
URL: https://github.com/apache/activemq-artemis/pull/2652#discussion_r279201228
##########
File path:
tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/tools/container/InVMInitialContextFactory.java
##########
@@ -104,10 +100,6 @@ public Context getInitialContext(final Hashtable<?, ?>
environment) throws Namin
}
}
- public static void reset() {
- InVMInitialContextFactory.initialContexts = new HashMap<>();
Review comment:
Nobody seems to be calling that, and it is in the tests part of the
codebase. If we want to keep it, then maybe calling `initialContexts.clear()`
(under whatever synchronization that is possibly required) would be sufficient.
If it needs further thought, I can drop it from the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
