wy96f commented on a change in pull request #2633: ARTEMIS-2317 Avoid long TTSP
caused by Page::read using mmap read
URL: https://github.com/apache/activemq-artemis/pull/2633#discussion_r279231448
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
##########
@@ -120,105 +110,133 @@ public void setLiveCache(LivePageCache pageCache) {
throw ActiveMQMessageBundle.BUNDLE.invalidPageIO();
}
- final List<PagedMessage> messages = new ArrayList<>();
-
size.lazySet((int) file.size());
- if (this.canBeMapped) {
- readFromMapped(storage, messages);
Review comment:
The original readFromSequentialFile() allocates file size memory and may
cause long TTSP.
But readFromMapped() only calls mmap64() and gets starting address of the
mapping which should not cause long TTSP. Why we not reserve mmap file read
here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
