franz1981 commented on a change in pull request #2633: ARTEMIS-2317 Avoid long
TTSP caused by Page::read using mmap read
URL: https://github.com/apache/activemq-artemis/pull/2633#discussion_r279241585
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
##########
@@ -120,105 +110,133 @@ public void setLiveCache(LivePageCache pageCache) {
throw ActiveMQMessageBundle.BUNDLE.invalidPageIO();
}
- final List<PagedMessage> messages = new ArrayList<>();
-
size.lazySet((int) file.size());
- if (this.canBeMapped) {
- readFromMapped(storage, messages);
Review comment:
The long TTSP issue of the mapped version wasn't caused during the cheap
mmap64, but while reading the MappedByteBuffer, on each new OS page that wasn't
mapped into the OS page cache.
The original version were having other issues eg memory footprint...but not
long TTSP.
This thread on
https://groups.google.com/forum/m/#!topic/mechanical-sympathy/yL4Yaedgqg4
explain in much detail that issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
