michaelandrepearce commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487476310 I agree about tone. And thats why i did not say MUST , and instead used SHOULD which means ideally but if not sensible or possible then it doesnt have to. What seems to be the case here is a blanket of changing of classes but without looking at what can be split out properly, only keeping those as nested classes where sensible. As in not a single class in this PR has become a class in its own right. I find that hard to believe
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
