michaelandrepearce commented on a change in pull request #2645: ARTEMIS-2321
Paging scalability and GC improvement
URL: https://github.com/apache/activemq-artemis/pull/2645#discussion_r279259143
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/utils/SoftValueLongObjectHashMap.java
##########
@@ -21,26 +21,26 @@
import java.util.ArrayList;
import java.util.Collection;
import java.util.Comparator;
-import java.util.HashMap;
-import java.util.HashSet;
+import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.TreeSet;
-import java.util.concurrent.atomic.AtomicLong;
+import io.netty.util.collection.LongObjectHashMap;
+import io.netty.util.collection.LongObjectMap;
import org.jboss.logging.Logger;
-public class SoftValueHashMap<K, V extends SoftValueHashMap.ValueCache>
implements Map<K, V> {
+public class SoftValueLongObjectHashMap<V extends
SoftValueLongObjectHashMap.ValueCache> implements LongObjectMap<V> {
- private static final Logger logger =
Logger.getLogger(SoftValueHashMap.class);
+ private static final Logger logger =
Logger.getLogger(SoftValueLongObjectHashMap.class);
// The soft references that are already good.
// too bad there's no way to override the queue method on ReferenceQueue,
so I wouldn't need this
private final ReferenceQueue<V> refQueue = new ReferenceQueue<>();
- private final Map<K, AggregatedSoftReference> mapDelegate = new HashMap<>();
+ private final LongObjectMap<AggregatedSoftReference<V>> mapDelegate = new
LongObjectHashMap<>();
Review comment:
Why do you need to make the field type use it directly? They implement map
interface. And the add primitive methods that will be invoked at runtime, you
dont need to make the field the concrete impl. This is the trick all primitive
impl use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
