michaelandrepearce commented on a change in pull request #2650: ARTEMIS-2320 Multiple math-related fixes URL: https://github.com/apache/activemq-artemis/pull/2650#discussion_r279261011
########## File path: artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/mapped/MappedSequentialFile.java ########## @@ -110,7 +110,7 @@ public void open(int maxIO, boolean useExecutor) throws IOException { @Override public boolean fits(int size) { checkIsOpen(); - final long newPosition = this.mappedFile.position() + size; + final long newPosition = (long) this.mappedFile.position() + size; final boolean hasRemaining = newPosition <= this.mappedFile.length(); Review comment: Ah yes i forgot about that. Good stuff ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services