jdanekrh commented on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone 
warning
URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487593830
 
 
   I'm not going to pull out any static nested classes into their own files. If 
this should get done, somebody more familiar with the codebase needs to do it. 
Possibly in a subsequent PR.
   
   I was thinking, we could configure the ClassCanBeStatic warning to be an 
error. Then all subsequently created nested classes that can be static would 
_have_ to be static, or not be nested.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to