michaelandrepearce edited a comment on issue #2651: ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487608496 So then i suggest leave the warning and dont add statics to just make it silent, warnings are there to suggest reviewing and refactoring code, its not just about finding the fastest sticky plaster to make the warning go away. But to really review the code, and refactor it properly. Its like code coverage, if you have a class that has low coverage, the solution isn't just to add tests quickly for all your getters and setters providing no value, but which would get coverage up just to silence the automated check, but really you should add better coverage to real code. The point being, don't hide an issue with a sticky plaster, go fix it properly, or leave the warning there, so it keeps getting noticed....
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
