clebertsuconic commented on a change in pull request #2655: ARTEMIS-2327 
ExceptionListener invoked when connection level exception
URL: https://github.com/apache/activemq-artemis/pull/2655#discussion_r280070256
 
 

 ##########
 File path: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
 ##########
 @@ -451,7 +451,9 @@ public Packet sendBlocking(final Packet packet,
             }
 
             if (response == null) {
-               throw 
ActiveMQClientMessageBundle.BUNDLE.timedOutSendingPacket(connection.getBlockingCallTimeout(),
 packet.getType());
+               ActiveMQException e = 
ActiveMQClientMessageBundle.BUNDLE.timedOutSendingPacket(connection.getBlockingCallTimeout(),
 packet.getType());
+               connection.fail(e);
 
 Review comment:
   @michaelandrepearce I ran the 2 hours:40 min test with on a jenkins server I 
have:
   ```
   mvn test -Ptests
   ```
   
   apparently there are tests hunging because of this.
   
   
   I couldn't figure out what test is it.. as the build generate zillions of:
   
   ```
   med out after waiting 2,000 ms for response when sending packet 32 
[code=CONNECTION_TIMEDOUT]
   [main] 09:19:18,204 WARN  [org.apache.activemq.artemis.core.client] 
AMQ212037: Connection failure has been detected: AMQ219014: Timed out after 
waiting 2,000 ms for response when sending packet 32 [code=CONNECTION_TIMEDOUT]
   2019-05-01 09:19:18,204 WARN  [org.apache.activemq.artemis.core.client] 
AMQ212037: Connection failure has been detected: AMQ219014: Timed out after 
waiting 2,000 ms for response when sending packet 32 [code=CONNECTION_TIMEDOUT]
   2019-05-01 09:19:18,204 WARN  [org.apache.activemq.artemis.core.client] 
AMQ212037: Connection failure has been detected: AMQ219014: Timed out after 
waiting 2,000 ms for response when sending packet 32 [code=CONNECTION_TIMEDOUT]
   [main] 09:19:20,210 WARN  [org.apache.activemq.artemis.core.client] 
AMQ212037: Connection failure has been detected: AMQ219014: Timed out after 
waiting 2,000 ms for response when sending packet 32 [code=CONNECTION_TIMEDOUT]
   2019-05-01 09:19:20,210 WARN  [org.apache.activemq.artemis.core.client] 
AMQ212037: Connection failure has been detected: AMQ219014: Timed out after 
waiting 2,000 ms for response when sending packet 32 [code=CONNECTION_TIMEDOUT]
   2019-05-01 09:19:20,210 WARN  [org.apache.activemq.artemis.core.client] 
AMQ212037: Connection failure has been detected: AMQ219014: Timed out after 
waiting 2,000 ms for response when sending packet 32 [code=CONNECTION_TIMEDOUT]
   [main] 09:19:22,216 WARN  [org.apache.activemq.artemis.core.client] 
AMQ212037: Connection failure has been detected: AMQ219014: Timed out after 
waiting 2,000 ms for response when sending packet 32 [code=CONNECTION_TIMEDOUT]
   2019-05-01 09:19:22,216 WARN  [org.apache.activemq.artemis.core.client] 
AMQ212037: Connection failure has been detected: AMQ219014: 
   ```
   
   
   I am taking a break today.. I can take a look on more details later today / 
tomorrow morning.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to