michaelandrepearce commented on a change in pull request #2655: ARTEMIS-2327
ExceptionListener invoked when connection level exception
URL: https://github.com/apache/activemq-artemis/pull/2655#discussion_r280432506
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java
##########
@@ -451,7 +451,9 @@ public Packet sendBlocking(final Packet packet,
}
if (response == null) {
- throw
ActiveMQClientMessageBundle.BUNDLE.timedOutSendingPacket(connection.getBlockingCallTimeout(),
packet.getType());
+ ActiveMQException e =
ActiveMQClientMessageBundle.BUNDLE.timedOutSendingPacket(connection.getBlockingCallTimeout(),
packet.getType());
+ connection.fail(e);
Review comment:
@clebertsuconic have just pushed a small change to that test, originally it
would just repeat the same over and over, where as test is just expecting it
ever to be called once, so made the interceptor in the test to adjust the
behaviour just the once using a bool
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services