jdanekrh commented on a change in pull request #2651: ARTEMIS-2320 Fix
ClassCanBeStatic errorprone warning
URL: https://github.com/apache/activemq-artemis/pull/2651#discussion_r279748160
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/DefaultSensitiveStringCodec.java
##########
@@ -182,7 +182,7 @@ public String encode(String secret) throws Exception {
}
}
- private class PBKDF2Algorithm extends CodecAlgorithm {
+ private static class PBKDF2Algorithm extends CodecAlgorithm {
Review comment:
make this top-level
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
