jdanekrh commented on a change in pull request #2643: ARTEMIS-2320 Update
javac-errorprone to 2.8.5 and error_prone_core to 2.3.3
URL: https://github.com/apache/activemq-artemis/pull/2643#discussion_r283219509
##########
File path:
artemis-junit/src/test/java/org/apache/activemq/artemis/junit/ActiveMQConsumerResourceTest.java
##########
@@ -50,7 +50,7 @@
ActiveMQConsumerResource consumer = new
ActiveMQConsumerResource(server.getVmURL(), TEST_QUEUE);
@Rule
- public RuleChain ruleChain = RuleChain.outerRule(new
ThreadLeakCheckRule()).outerRule(server).around(consumer);
+ public RuleChain ruleChain = RuleChain.outerRule(new
ThreadLeakCheckRule()).around(server).around(consumer);
Review comment:
Trying this on multiple machines, outside of debug mode it passes on my rhel
vm, but not on bare metal laptop. When running under debugger, it passes
everywhere. I have the same problem with other tests that use this rulechain
construct, such as `MultipleEmbeddedActiveMQResourcesTest`.
```
*********************************************************************************
LEAKING THREADS
=============================================================================
Thread Thread[Attach Listener,9,system] is still alive with the following
stackTrace:
*********************************************************************************
[main] 09:39:58,447 INFO
[org.apache.activemq.artemis.junit.ThreadLeakCheckRule] #test forceGC
[main] 09:39:58,500 INFO
[org.apache.activemq.artemis.junit.ThreadLeakCheckRule] #test forceGC Done
*********************************************************************************
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
