franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero
copy to replicate journal/page/large message file
URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r283269072
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationSyncFileMessage.java
##########
@@ -197,6 +232,15 @@ public void decodeRest(final ActiveMQBuffer buffer) {
}
}
+ private void readFile(ByteBuffer buffer) {
+ try (FileInputStream fis = new FileInputStream(file); FileChannel
channel = fis.getChannel()) {
+ channel.position(offset);
+ channel.read(buffer);
Review comment:
> We only get here for the InVM connection where we use in our test, so it
doesn't matter with the performance
Not sure about it, EAP and other products based on Artemis use InVM
connections...
maybe not with replication @jbertram @clebertsuconic any ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
