michaelandrepearce commented on a change in pull request #2666: ARTEMIS-2336
Use zero copy to replicate journal/page/large message file
URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r284485851
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationSyncFileMessage.java
##########
@@ -197,6 +232,15 @@ public void decodeRest(final ActiveMQBuffer buffer) {
}
}
+ private void readFile(ByteBuffer buffer) {
+ try (FileInputStream fis = new FileInputStream(file); FileChannel
channel = fis.getChannel()) {
+ channel.position(offset);
+ channel.read(buffer);
Review comment:
InVM is very important for performance. There is a use case at a company i
know heavily reliant on InVM perf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
