franz1981 commented on a change in pull request #2666: ARTEMIS-2336 Use zero
copy to replicate journal/page/large message file
URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r284583148
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/invm/InVMConnection.java
##########
@@ -237,6 +240,22 @@ public void run() {
}
+ @Override
+ public void write(ActiveMQBuffer buffer,
+ RandomAccessFile raf,
+ FileChannel fileChannel,
+ long offset,
+ int dataSize,
+ boolean closeChannel) {
+ try {
+ if (closeChannel)
Review comment:
This method is correct that's empty?
Anyway please use a proper logger here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
