wy96f commented on a change in pull request #2666: ARTEMIS-2336 Use zero copy
to replicate journal/page/large message file
URL: https://github.com/apache/activemq-artemis/pull/2666#discussion_r285094410
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
##########
@@ -385,6 +402,34 @@ public final void write(ActiveMQBuffer buffer,
}
}
+ @Override
+ public void write(ActiveMQBuffer buffer,
Review comment:
Do you mean we call write twice, first write buffer api, second new write
file api in channel::send()? This way we will call netty channel::writeAndFlush
twice, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
