ldebello edited a comment on issue #2686: ARTEMIS-2361 Bridge should make a copy of messages URL: https://github.com/apache/activemq-artemis/pull/2686#issuecomment-497080134 @clebertsuconic I know you close https://github.com/apache/activemq-artemis/pull/2682 because this ticket will solve it, but the changes here seems against the idea of leaving the responsibility to transform to reencode the message when adding property (https://github.com/apache/activemq-artemis/pull/2634). Because as far as understand marking the message as changed in the divert will reencode it in the future (https://github.com/apache/activemq-artemis/pull/2686/files#diff-565f29f5e7c3e5234faff2352404eedbR129). ~~I am not totally sure but based on the changes I think the properties added by a transformer in the divert will work out of the box but properties added in a transform in a bridge will not work, so that could be misleading. ~~ I have just tested this case and it works ok, and it makes sense :) after looking again at the change. Anyway I also check that removing the reencode from the transformer works, for my that is great but in theory it was not the original idea
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
