clebertsuconic commented on a change in pull request #2695: ARTEMIS-2372 
Filtering on Message Annotations
URL: https://github.com/apache/activemq-artemis/pull/2695#discussion_r290935730
 
 

 ##########
 File path: 
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
 ##########
 @@ -1263,7 +1263,10 @@ public Long getLongProperty(String key) throws 
ActiveMQPropertyConversionExcepti
 
    @Override
    public Object getObjectProperty(String key) {
-      if (key.equals(MessageUtil.TYPE_HEADER_NAME.toString())) {
+
+      if 
(key.startsWith(AMQPMessageSupport.JMS_AMQP_MESSAGE_ANNOTATION_PREFIX)) {
 
 Review comment:
   @tabish121 getObjectProperty is only used on the server's side for 
filtering. This is just leverating what's already implemented through 
setAnnotation, and Message.referenceOriginalMessage
   
   After the message is copied to DLQ or ExpiryQueue, this will allow what's in 
there to be filtered.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to