clebertsuconic commented on a change in pull request #2694: ARTEMIS-2371
Message with huge header shuts broker down
URL: https://github.com/apache/activemq-artemis/pull/2694#discussion_r292037837
##########
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/journal/ActiveMQJournalBundle.java
##########
@@ -47,4 +47,7 @@
@Message(id = 149004, value = "unable to open file")
String unableToOpenFile();
+
+ @Message(id = 149005, value = "Record (size={0}) larger than the store
maxRecordSize({1})", format = Message.Format.MESSAGE_FORMAT)
Review comment:
please, use a more user friendly message... something that would make sense
to an user...
"Your message is storing too much data as part of properties
(maxSize=maxSize). Store large data as part of the MessageBody"
Something like that.. I dunno.. this is just a suggestion.
this is actually the reason I asked you to change the test.. if you ever
change the english grammar, translations.. whateverthe test will be broken.
Test based on the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
