brusdev commented on a change in pull request #2707: ARTEMIS-2002 Proton
transport objects leaked if client disconnects abruptly
URL: https://github.com/apache/activemq-artemis/pull/2707#discussion_r294625910
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
##########
@@ -183,6 +188,11 @@ public void flush() {
}
public void close(ErrorCondition errorCondition) {
+ if (scheduledPool != null && scheduledPool instanceof ThreadPoolExecutor
&&
Review comment:
The scheduledPool RemoveOnCancelPolicy is false so If I cancel the task it
won't be removed from the queue and the garbage collector can't delete it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
