cjwmorgan-sol commented on issue #4: [WIP] Failover implementation URL: https://github.com/apache/activemq-nms-amqp/pull/4#issuecomment-503574659 @michaelandrepearce Session indeed do not require a dedicated thread per session. They do require serialized execution of message delivery callbacks that are independent from other sessions. See JMS 1.0 sections 4.4.16 and 4.4.17. AmqpNetLite transport thread is used to give amqpnetlite callbacks for message delivery that transport thread is used for all resources under the amqp connection so the current WIP implementation satisfies section 4.4.16 for Serialized Client Code execution but not section 4.4.17 for Concurrent Message Delivery. As blocking the transport thread would block all other sessions message delivery callbacks. I thought that a dotnet threadpool or task scheduling approach might be better instead of a dedicated thread approach to satisfy sections 4.4.16 and 4.4.17.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
