gaohoward commented on a change in pull request #2725: AETEMIS-2390
JMSMessageID header can be null when messages are cross-protocol
URL: https://github.com/apache/activemq-artemis/pull/2725#discussion_r296259576
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AmqpCoreConverter.java
##########
@@ -345,6 +346,12 @@ private static ServerJMSMessage
processProperties(ServerJMSMessage jms, Properti
}
}
Object correlationID = properties.getCorrelationId();
+
+ if (properties.getMessageId() != null) {
+ //core jms clients get JMSMessageID from UserID which is a UUID
object
+
jms.getInnerMessage().setUserID(UUIDGenerator.getInstance().generateUUID());
Review comment:
Looks like proton-j maps to java UUID, but the core message using it's own
UUID type.
If we preserve the original uuid, we need to convert the type. I'll take a
look at the code and what need to be changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
