gemmellr commented on a change in pull request #2725: AETEMIS-2390 JMSMessageID
header can be null when messages are cross-protocol
URL: https://github.com/apache/activemq-artemis/pull/2725#discussion_r296752378
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AmqpCoreConverter.java
##########
@@ -345,6 +347,17 @@ private static ServerJMSMessage
processProperties(ServerJMSMessage jms, Properti
}
}
Object correlationID = properties.getCorrelationId();
+
+ if (properties.getMessageId() != null) {
Review comment:
This seems like it should move up beside the other message id handling at
the top of the method. Its strange this happens much later, right after getting
the correlation-id value and before the actual subsequent use of that
correlation-id value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
