jbertram edited a comment on issue #2731: [ARTEMIS-2401]: Implement the Pause method for a Topic URL: https://github.com/apache/activemq-artemis/pull/2731#issuecomment-505557860 Since pausing an address is essentially just pausing all of the bound queues (i.e. not the actual consumers) I think the method names should reflect that. Therefore, I recommend using `pause()`, `resume()`, & `isPaused()`. The `AddressControl` should also expose `paused` so users can determine whether or not an address is paused administratively. Also, the commit message doesn't need any square brackets of colons, and it should refer to core resources (i.e. "address" instead of "topic"). Lastly, I think you'll want to persist the paused status of the address to avoid confusion when an address is paused and the broker is restarted. In this case all of the bound queues will still be paused (since queues persist their paused status), but when looking at the address administratively or programmatically it will appear that it is not paused.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
