franz1981 commented on a change in pull request #2730: ARTEMIS-2399 Fix
performance degradation when there are a lot of subscribers
URL: https://github.com/apache/activemq-artemis/pull/2730#discussion_r297500166
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
##########
@@ -312,6 +451,10 @@ public void close() throws Exception {
* While reading the cache we don't need (and shouldn't inform the backup
*/
public synchronized void close(boolean sendEvent) throws Exception {
+ if (readFileBuffer != null) {
+ fileFactory.releaseBuffer(readFileBuffer);
Review comment:
Currently the NIO pool is thread local, so I'm not sure is a good idea to do
this on different threads (very likely).
We could implement a non-thread local pool or (better), do not use the pool
but directly direct ByteBuffer instances obtained from the factory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
