brusdev commented on a change in pull request #2727: ARTEMIS-2394 Improve
scheduling sync for AMQPConnectionContext
URL: https://github.com/apache/activemq-artemis/pull/2727#discussion_r298007696
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
##########
@@ -87,9 +89,8 @@
private final boolean useCoreSubscriptionNaming;
- private boolean isSchedulingCancelled;
- private ScheduledFuture scheduledFuture;
- private final Object schedulingLock = new Object();
+ private static final FutureTask<Void> voidFuture = new FutureTask<>(() -> {
}, null);
Review comment:
ScheduledFutureRef is used for 2 purpose: keeping the last scheduledFuture
and the scheduling status, so I need tree states for scheduledFutureRef:
- VOID_FUTURE before onRemoteOpen / NOT SCHEDULED / SCHEDULING ALLOWED
- NULL after close / SCHEDULING NOT ALLOWED
- ELSE after onRemoteOpen and before close / SCHEDULED / SCHEDULING ALLOWED
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
