michaelandrepearce commented on a change in pull request #2731: [ARTEMIS-2401]:
Implement the Pause method for a Topic
URL: https://github.com/apache/activemq-artemis/pull/2731#discussion_r298477794
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java
##########
@@ -1481,6 +1509,7 @@ public JournalLoadInformation loadBindingJournal(final
List<QueueBindingInfo> qu
} else if (rec == JournalRecordIds.ADDRESS_BINDING_RECORD) {
PersistentAddressBindingEncoding bindingEncoding =
newAddressBindingEncoding(id, buffer);
addressBindingInfos.add(bindingEncoding);
+ mapAddressBindings.put(id, bindingEncoding);
} else if (rec == JournalRecordIds.GROUP_RECORD) {
Review comment:
Is the a compatibility test to ensure broker upgrade downgrade there is no
issues with bindings. E.g. old broker can read new binding files ok (eg ignores
without issue the new data), and new broker version can read old generated
binding files (eg handles missing record and defaults)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
