jbertram commented on a change in pull request #2731: [ARTEMIS-2401]: Implement
the Pause method for a Topic
URL: https://github.com/apache/activemq-artemis/pull/2731#discussion_r298582545
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/AddressControlImpl.java
##########
@@ -373,6 +372,86 @@ public String sendMessage(final Map<String, String>
headers,
return MBeanInfoHelper.getMBeanAttributesInfo(AddressControl.class);
}
+ @Override
+ public void pause() throws Exception {
+ pause(false);
+ }
+
+ @Override
+ public void pause(boolean persist) throws Exception {
+ if (AuditLogger.isEnabled()) {
+ AuditLogger.pause(addressInfo);
+ }
+ checkStarted();
+
+ clearIO();
+ try {
+ if (!addressInfo.isPaused()) {
+ addressInfo.pause();
+ if (persist) {
+
server.getStorageManager().storeAddressStatus(addressInfo.getId(),
AddressStatus.PAUSED);
+ }
Review comment:
I think this logic should be moved into the `AddressInfo#pause` method so
users of `AddressInfo` get the persistence functionality without having to use
the control object. Also, there needs to be a way to detect multiple
invocations of `pause` so that PAUSED records don't just keep getting added
over and over as that will cause the bindings journal size to increase over
time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
