clebertsuconic commented on a change in pull request #2731: [ARTEMIS-2401]:
Implement the Pause method for a Topic
URL: https://github.com/apache/activemq-artemis/pull/2731#discussion_r298654347
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/AddressControlImpl.java
##########
@@ -373,6 +372,86 @@ public String sendMessage(final Map<String, String>
headers,
return MBeanInfoHelper.getMBeanAttributesInfo(AddressControl.class);
}
+ @Override
+ public void pause() throws Exception {
+ pause(false);
+ }
+
+ @Override
+ public void pause(boolean persist) throws Exception {
+ if (AuditLogger.isEnabled()) {
+ AuditLogger.pause(addressInfo);
+ }
+ checkStarted();
+
+ clearIO();
+ try {
+ if (!addressInfo.isPaused()) {
+ addressInfo.pause();
+ if (persist) {
+
server.getStorageManager().storeAddressStatus(addressInfo.getId(),
AddressStatus.PAUSED);
+ }
Review comment:
A simple solution would be to create a setter on Addressinfo, and we call
the setter right before we call the pause method.
We could throw an IllegalSTateException if the server is not informed. So
the API would be... setServer(server);addressInfo.pause(true/false);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
