franz1981 commented on a change in pull request #2741: ARTEMIS-2415 JDBCJournal
miss pending tasks during shutdown
URL: https://github.com/apache/activemq-artemis/pull/2741#discussion_r300588314
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/JournalStorageManager.java
##########
@@ -86,6 +87,8 @@
protected ReplicationManager replicator;
+ protected final AtomicInteger deletingLargeMessageTasks = new
AtomicInteger(0);
Review comment:
I would put this logic just into `JDBCJournalStorageManager` while exposing
here these callbacks:
```java
protected void beforeSubmitDeleteLargeMessageRequest() {
}
protected void afterDeleteLargeMessageCompleted() {
}
protected void afterDeleteLargeMessageError(int code, String errorMessage) {
}
```
The names could be improved, but the idea would be to let just JDBC part to
care about this (unless we know that the storage manager need to handle this
too), wdyt?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
